Well the poll below only has 5 votes for armourcraft and 6 for weaponsmith and only 1 reply but with this poll id like for people to say why; for know i havent really decided but i am leaning towards armourcraft of course i will explain my reason why;
With weaponsmith you make weapons paladins can only use one weapon they start of with a weapon that will probley last until there level 30 then they buy/make a new weapon better than there old and which can hopefully last until level 40 there weapons sell for 1-5k *rough money correct me if you want* (of course adventually come level 68 buy weapon will cost 90-100k can you also make that weapon aswell?)
Armourcraft - I don't know alot about prices for high levels, but i have to say there are 4 pieces of armour *correct me if i am wrong* boots, gaunlets, helmet, body like i said before the stuff you start off with will last until level 30 but this time you will need to pay 4x as much as a weapon, what else can i say? i don't know how much you can sell armour for (maybe at a high level you'll be able to make 90-100k armour worth) and not just paying 4x in price but armour helps you fight stronger monsters where as a weapon will not be that better and will only allow you to kill faster.
It truley is a good competition but when i look at it like this then hands down Armourcraft wins because i don't want to waste money.